Make desktop alerting independent from notification support in the homeserver #707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepbluev7
reviewed
Sep 3, 2021
Thulinma
force-pushed
the
alerts_working_without_homeserver_support
branch
3 times, most recently
from
7b9ef73
to
126e417
Compare
deepbluev7
reviewed
Sep 3, 2021
Thulinma
force-pushed
the
alerts_working_without_homeserver_support
branch
from
60e4a45
to
f3dd489
Compare
Thulinma
force-pushed
the
alerts_working_without_homeserver_support
branch
from
f3dd489
to
6bd62f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this needs much explanation..? This should be fine, as it's impossible to double-alert a window that is already alerting.