Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor relations for edits #48

Merged
merged 4 commits into from
Feb 10, 2021
Merged

Refactor relations for edits #48

merged 4 commits into from
Feb 10, 2021

Conversation

deepbluev7
Copy link
Member

No description provided.

@deepbluev7 deepbluev7 marked this pull request as draft January 26, 2021 02:50
@codecov
Copy link

codecov bot commented Jan 26, 2021

Codecov Report

Merging #48 (ec71ff2) into master (4951190) will decrease coverage by 0.32%.
The diff coverage is 60.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
- Coverage   68.70%   68.37%   -0.33%     
==========================================
  Files          79       79              
  Lines        4304     4351      +47     
==========================================
+ Hits         2957     2975      +18     
- Misses       1347     1376      +29     
Impacted Files Coverage Δ
include/mtx/events_impl.hpp 79.46% <40.00%> (-4.35%) ⬇️
lib/structs/events/messages/audio.cpp 50.00% <50.00%> (ø)
lib/structs/events/messages/notice.cpp 53.33% <50.00%> (-2.92%) ⬇️
lib/structs/events/messages/video.cpp 50.00% <50.00%> (ø)
lib/structs/events/common.cpp 62.61% <51.16%> (-10.25%) ⬇️
lib/structs/events/messages/image.cpp 71.87% <75.00%> (-0.35%) ⬇️
lib/structs/events/encrypted.cpp 73.50% <85.71%> (+3.71%) ⬆️
lib/structs/events/messages/file.cpp 86.36% <85.71%> (-4.95%) ⬇️
lib/structs/events/messages/emote.cpp 86.66% <100.00%> (+4.31%) ⬆️
lib/structs/events/messages/text.cpp 86.66% <100.00%> (-1.57%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4951190...31e3005. Read the comment docs.

@deepbluev7 deepbluev7 marked this pull request as ready for review February 10, 2021 13:12
@deepbluev7 deepbluev7 merged commit 004d420 into master Feb 10, 2021
@deepbluev7 deepbluev7 deleted the edit-implementation branch March 13, 2021 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant