Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage #4125

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

snordmann
Copy link

In this PR my goal is to test more endpoints and maybe even the frontend. This should make verification of future changes easier.

@snordmann
Copy link
Author

One thing that I noticed relating to the tests: The GET response for /api/proxy-hosts schema does not verify. The certificate property is not set on the returned proxy-hosts.

How should this be fixed? I see two options:

  • (a) Edit the schema to make certificate an optional property
  • (b) Adjust the backend to always include the certificate property

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant