Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: increase max number of domains to 100 (match with Let's Encrypt) #3581

Merged
merged 2 commits into from
Feb 27, 2024

Conversation

davidindra
Copy link
Contributor

@davidindra davidindra commented Feb 23, 2024

CC @jc21

Let's make the limit of domains count equal to the Let's Encrypt limit, as suggested here #3382 (comment), when the limit was raised from 15 to 30 in last December.

In my use case, I have a big SAN cert - lots of subdomains and "www." is needed to be supported too, so everything twice; I am not able to configure this in nginx-proxy-manager at the moment.

ref: #3218, #3382

I would be glad if you could approve & merge this change :)
Thx and have a nice day,

D.

@nginxproxymanagerci
Copy link

Docker Image for build 2 is available on DockerHub as jc21/nginx-proxy-manager:github-pr-3581

Note: ensure you backup your NPM instance before testing this PR image! Especially if this PR contains database changes.

@jc21 jc21 merged commit 63cd9ba into NginxProxyManager:develop Feb 27, 2024
1 check passed
@davidindra
Copy link
Contributor Author

Thanks @jc21! 🙂 Could you say when you will make a new release to the :latest Docker tag?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants