Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT] PageIndicator component 추가 #33

Merged
merged 3 commits into from
Feb 7, 2024
Merged

[FEAT] PageIndicator component 추가 #33

merged 3 commits into from
Feb 7, 2024

Conversation

josushell
Copy link
Member

  • page indicator를 UI component로 분리했습니다
  • 파라미터에 PagerState를 전달해주면 됩니다~
스크린샷 2024-02-07 오후 10 31 36

@josushell josushell added the feature New feature or request label Feb 7, 2024
@josushell josushell self-assigned this Feb 7, 2024
@easyhooon
Copy link
Collaborator

오 나도 쓰는 화면이 있는데 가져다 쓰면 되겠구만

easyhooon
easyhooon reviewed Feb 7, 2024
View reviewed changes
core/ui/src/main/kotlin/com/nexters/ilab/core/ui/component/PageIndicator.kt Outdated
@Composable
internal fun PagerIndicator(pagerState: PagerState) {
Row(
Modifier
Copy link
Collaborator

@easyhooon easyhooon Feb 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Modifier
modifier = Modifier

easyhooon
easyhooon approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@easyhooon easyhooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josushell josushell merged commit eba293e into develop Feb 7, 2024
1 check passed
@josushell josushell deleted the feature/page_indicator branch February 7, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyhooon easyhooon easyhooon approved these changes

Assignees

@josushell josushell

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josushell @easyhooon