Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEAT][#5] TopAppBar component 수정 및 에셋 추가 #30

Merged
merged 3 commits into from
Feb 5, 2024
Merged

[FEAT][#5] TopAppBar component 수정 및 에셋 추가 #30

merged 3 commits into from
Feb 5, 2024

Conversation

josushell
Copy link
Member

스크린샷 2024-02-04 오전 11 08 51 스크린샷 2024-02-04 오전 11 11 54
  • TopAppBar 컴포넌트를 setting 화면으로 이어질 수 있도록 setting enum 값 추가했으
  • 홈 화면의 경우에는 텍스트 로고가 CenterStart로 되어 있어서 그 부분은 파라미터에 isTextLogo bool 값으로 받아서 로고만 처리하도록 했어
  • default 값은 false라서 다른 TopAppBar에는 영향 없어~

@josushell josushell added the feature New feature or request label Feb 4, 2024
@josushell josushell self-assigned this Feb 4, 2024
@josushell josushell linked an issue Feb 4, 2024 that may be closed by this pull request
홈 화면 UI #5
Closed
1 task
@josushell josushell removed a link to an issue Feb 4, 2024
홈 화면 UI #5
Closed
1 task
easyhooon
easyhooon approved these changes Feb 4, 2024
View reviewed changes
Copy link
Collaborator

@easyhooon easyhooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굿!

@josushell josushell merged commit d35412f into develop Feb 5, 2024
1 check passed
@josushell josushell deleted the feature/home-ui branch February 5, 2024 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyhooon easyhooon easyhooon approved these changes

Assignees

@josushell josushell

Labels
feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josushell @easyhooon