-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT][#97] MyPage Album 이미지 삭제 API 연결 #100
Merged
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
881ac7a
[FEAT][#97] MyPage Album 이미지 삭제 API 연결
josushell 51ecc93
[FEAT] 함수명 통일
easyhooon 300df91
[FIX][#97] Delete My Album Service Path 수정
josushell 394b432
[FIX][#97] DeleteMyAlbum thumbnailId 파라미터 수정
josushell 2a43803
[FEAT] MyAlbum 클릭 이벤트 로직 수정 및 로그 호출 함수 주석 처리
easyhooon 4f6a2ea
[CHORE] style check success
easyhooon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
7 changes: 7 additions & 0 deletions
7
.../src/main/kotlin/com/nexters/ilab/android/core/data/datasource/DeleteMyAlbumDataSource.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package com.nexters.ilab.android.core.data.datasource | ||
|
||
import com.nexters.ilab.android.core.data.response.UserInfoResponse | ||
|
||
interface DeleteMyAlbumDataSource { | ||
suspend fun deleteMyAlbum(uuid: Long, thumbnailId: Int): UserInfoResponse | ||
} |
13 changes: 13 additions & 0 deletions
13
.../main/kotlin/com/nexters/ilab/android/core/data/datasource/DeleteMyAlbumDataSourceImpl.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package com.nexters.ilab.android.core.data.datasource | ||
|
||
import com.nexters.ilab.android.core.data.response.UserInfoResponse | ||
import com.nexters.ilab.android.core.data.service.ILabService | ||
import javax.inject.Inject | ||
|
||
class DeleteMyAlbumDataSourceImpl @Inject constructor( | ||
private val service: ILabService, | ||
) : DeleteMyAlbumDataSource { | ||
override suspend fun deleteMyAlbum(uuid: Long, thumbnailId: Int): UserInfoResponse { | ||
return service.deleteMyAlbumImage(uuid, thumbnailId) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
.../main/kotlin/com/nexters/ilab/android/core/data/repository/DeleteMyAlbumRepositoryImpl.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
package com.nexters.ilab.android.core.data.repository | ||
|
||
import com.nexters.ilab.android.core.data.datasource.DeleteMyAlbumDataSource | ||
import com.nexters.ilab.android.core.data.mapper.toEntity | ||
import com.nexters.ilab.android.core.data.util.runSuspendCatching | ||
import com.nexters.ilab.android.core.datastore.TokenDataSource | ||
import com.nexters.ilab.android.core.domain.repository.DeleteMyAlbumRepository | ||
import javax.inject.Inject | ||
|
||
class DeleteMyAlbumRepositoryImpl @Inject constructor( | ||
private val tokenDataSource: TokenDataSource, | ||
private val myAlbumDataSource: DeleteMyAlbumDataSource, | ||
) : DeleteMyAlbumRepository { | ||
override suspend fun deleteMyAlbum(thumbnailId: Int) = runSuspendCatching { | ||
val uuid = tokenDataSource.getUUID() | ||
myAlbumDataSource.deleteMyAlbum(uuid, thumbnailId).toEntity() | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
...rc/main/kotlin/com/nexters/ilab/android/core/domain/repository/DeleteMyAlbumRepository.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
package com.nexters.ilab.android.core.domain.repository | ||
|
||
import com.nexters.ilab.android.core.domain.entity.UserInfoEntity | ||
|
||
interface DeleteMyAlbumRepository { | ||
suspend fun deleteMyAlbum(thumbnailId: Int): Result<UserInfoEntity> | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
...re/home/src/main/kotlin/com/nexters/ilab/android/feature/home/viewmodel/HomeSideEffect.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
package com.nexters.ilab.android.feature.home.viewmodel | ||
|
||
sealed interface HomeSideEffect { | ||
data class OnCreateImageButtonClickFromStyle(val selectedStyle: String) : HomeSideEffect | ||
data class OnCreateImageButtonClickFromProfile(val selectedProfile: String) : HomeSideEffect | ||
data class OnCreateImageBtnClickFromStyle(val selectedStyle: String) : HomeSideEffect | ||
data class OnCreateImageBtnClickFromProfile(val selectedProfile: String) : HomeSideEffect | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 Path 잘 못 들어간거같음
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
헉 그렇네 왜 이래