[Feature/#178] 온보딩(Guide) 화면 구현 #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
JongHoooon
reviewed
Aug 23, 2024
| ZStack(alignment: .bottom) { | ||
| GeometryReader { geometry in | ||
| let width = geometry.size.width | ||
| let bottleArrivalImageWidth = max(width - 72, 0) |
There was a problem hiding this comment.
72 같은거(매직 넘버) 상수로 선언해서 추후에 다시 봤을 때 무슨의미인지 알 수있게 해주면 좋을거같아!
leemhyungyu
force-pushed
the
feature/#178-GuideFeature
branch
from
18f8e57
to
9d939ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 #178
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-08-23.at.19.05.51.mov
완료된 기능
전달 사항