Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new
free()
now marks memory with0xDD
BusFault
handler checks for0xDDDDDDDD
and 64K after it to determine "Possible use-after-free"furi_semaphore_release()
:rpc_cli_command_start_session()
is waiting forfuri_semaphore_acquire()
rpc_cli_session_terminated_callback()
willfuri_semaphore_release()
rpc_cli_command_start_session()
which then does furi_semaphore_free()furi_semaphore_release()
inside ofrpc_cli_session_terminated_callback()
resumes, and dereferences the semaphore thatrpc_cli_command_start_session()
has already free'dFor the reviewer