Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrared: Add option to "Load from Library File" for Universal Remotes #255

Merged
merged 25 commits into from
Oct 12, 2024
Merged

Infrared: Add option to "Load from Library File" for Universal Remotes #255

merged 25 commits into from
Oct 12, 2024

Conversation

zxkmm
Copy link
Contributor

@zxkmm zxkmm commented Oct 10, 2024 •
edited by Willy-JL
Loading

What's new

  • add an entrance in IR universal submenu to load custom db

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

@zxkmm zxkmm marked this pull request as ready for review October 10, 2024 09:47
Willy-JL
Willy-JL requested changes Oct 11, 2024
View reviewed changes
Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty solid work, but a few things can be ironed out. ill work on these improvements right away 😄

applications/main/infrared/infrared_brute_force.c Outdated Show resolved Hide resolved
applications/main/infrared/infrared_brute_force.c Outdated Show resolved Hide resolved
applications/main/infrared/infrared_brute_force.c Outdated Show resolved Hide resolved
applications/main/infrared/scenes/infrared_scene_universal.c Outdated Show resolved Hide resolved
applications/main/infrared/scenes/infrared_scene_universal_more_devices.c Outdated Show resolved Hide resolved
applications/main/infrared/scenes/infrared_scene_universal_more_devices.c Outdated Show resolved Hide resolved
Willy-JL
Willy-JL approved these changes Oct 11, 2024
View reviewed changes
Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i ended up changing more than i intended, but i think its now in great shape :D what do you think @zxkmm ?

@Willy-JL Willy-JL added the feature New feature or request label Oct 11, 2024
@Willy-JL Willy-JL changed the title add an entrance in IR universal submenu to load custom db Infrared: Add option to "Load from Library File" for Universal Remotes Oct 11, 2024
@zxkmm
Copy link
Contributor Author

zxkmm commented Oct 12, 2024

Ohhhhh, your change is so nice and elegant! Thank you so much! I didn't realize I missed that many parts! It's really nice and LGTM.

Also regarding the changelog name I'm not sure if i deserver it, since you re-wrote the entire work (with better code) already, so maybe add your name too?

Thank you so much and it's working better now

@Willy-JL Willy-JL merged commit 2f22fad into Next-Flip:dev Oct 12, 2024
2 checks passed
@zxkmm zxkmm deleted the ir_custom_universal branch October 12, 2024 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaylikesbunda jaylikesbunda jaylikesbunda left review comments

@Willy-JL Willy-JL Willy-JL approved these changes

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich is a code owner

Assignees

@zxkmm zxkmm

Labels
feature New feature or request
Projects
Momentum Progress Tracker
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zxkmm @Willy-JL @jaylikesbunda