Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

46 tpetra multi vector adapter #57

Open
wants to merge 1 commit into
base: NGA-FY23-develop
Choose a base branch
from

Conversation

mperrinel
Copy link
Collaborator

@mperrinel mperrinel commented Jul 20, 2023

Fixed #46

@mperrinel mperrinel marked this pull request as ready for review July 20, 2023 13:00
@mperrinel mperrinel marked this pull request as draft July 20, 2023 13:00
@mperrinel mperrinel marked this pull request as ready for review July 24, 2023 09:46
@JacobDomagala
Copy link
Collaborator

Is this ready to be reviewed? TpetraMultiVectorAdapter should provide new API (Host/Device) and there's no need to define the old one (we could rely on base implementation or throw exception saying this API is deprecated and point to new one).

@mperrinel
Copy link
Collaborator Author

TpetraMultiVectorAdapter is the tpetra conversion of XpetraMultiVectorAdapter. It has been started on the top of NGA-FY23-develop which doesn't contain new API (Host/Device) on VectorAdapter (need to wait for the PR validation). We can indeed wait for it in order to rebase the PR. For the need of defining the old one. It is a good point. For me it is just an intermediary step which correspond to the conversion from Xpetra to Tpetra.

@JacobDomagala
Copy link
Collaborator

Unless I'm missing something, the only new part introduced by the VectorAdapter is Elements getter, the rest is already on develop and is the part of BaseAdapter.
But all right, I'll wait when it's ready : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoltan2: Convert XpetraMultiVectorAdapter to Tpetra
3 participants