-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#210: Belos: replace hb reader tpetra #214
base: NGA-FY23-develop
Are you sure you want to change the base?
#210: Belos: replace hb reader tpetra #214
Conversation
⚡ Code quality check ⚡ 🔴 clang-tidy found 37 issues! Click here to see details.Trilinos/packages/belos/tpetra/example/BlockCG/BlockCGTpetraExFile.cpp Lines 117 to 122 in 6b8ca47
!Line: 117 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] Trilinos/packages/belos/tpetra/example/BlockCG/PseudoBlockCGTpetraExFile.cpp Lines 117 to 122 in 6b8ca47
!Line: 117 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] Trilinos/packages/belos/tpetra/example/BlockCG/PseudoBlockCGTpetraExFile.cpp Lines 133 to 138 in 6b8ca47
!Line: 133 - warning: variable 'map' is not initialized [cppcoreguidelines-init-variables]
!Line: 282 - note: +1
!Line: 155 - note: +1, including nesting penalty of 0, nesting level increased to 1
!Line: 159 - note: +1, including nesting penalty of 0, nesting level increased to 1
!Line: 167 - note: +1, nesting level increased to 1
!Line: 216 - note: +3, including nesting penalty of 2, nesting level increased to 3 Trilinos/packages/belos/tpetra/test/TFQMR/test_tfqmr_hb.cpp Lines 124 to 129 in 6b8ca47
!Line: 124 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] Trilinos/packages/belos/tpetra/test/TFQMR/test_tfqmr_hb.cpp Lines 133 to 138 in 6b8ca47
!Line: 133 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] Trilinos/packages/belos/tpetra/test/TFQMR/test_tfqmr_hb.cpp Lines 133 to 138 in 6b8ca47
!Line: 133 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] Trilinos/packages/belos/tpetra/test/TFQMR/test_tfqmr_hb.cpp Lines 167 to 172 in 6b8ca47
!Line: 167 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] Trilinos/packages/belos/tpetra/test/TFQMR/test_tfqmr_hb.cpp Lines 216 to 221 in 6b8ca47
!Line: 216 - warning: statement should be inside braces [google-readability-braces-around-statements,hicpp-braces-around-statements,readability-braces-around-statements] Trilinos/packages/belos/tpetra/example/BlockGmres/BlockGmresTpetraExFile.cpp Lines 122 to 127 in 6b8ca47
!Line: 122 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] Trilinos/packages/belos/tpetra/example/BlockGmres/BlockGmresTpetraExFile.cpp Lines 143 to 148 in 6b8ca47
!Line: 143 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] Trilinos/packages/belos/tpetra/example/BlockGmres/BlockGmresTpetraExFile.cpp Lines 143 to 148 in 6b8ca47
!Line: 143 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] Trilinos/packages/belos/tpetra/example/BlockGmres/BlockGmresTpetraExFile.cpp Lines 145 to 150 in 6b8ca47
!Line: 145 - warning: variable 'map' is not initialized [cppcoreguidelines-init-variables] Trilinos/packages/belos/tpetra/example/BlockGmres/BlockGmresTpetraExFile.cpp Lines 222 to 227 in 6b8ca47
!Line: 222 - warning: variable 'resid' is not initialized [cppcoreguidelines-init-variables] Trilinos/packages/belos/tpetra/test/GCRODR/test_gcrodr_hb.cpp Lines 131 to 136 in 6b8ca47
!Line: 131 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] Trilinos/packages/belos/tpetra/test/GCRODR/test_gcrodr_hb.cpp Lines 131 to 136 in 6b8ca47
!Line: 131 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] Trilinos/packages/belos/tpetra/test/BiCGStab/test_bicgstab_hb.cpp Lines 123 to 128 in 6b8ca47
!Line: 123 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] Trilinos/packages/belos/tpetra/test/BiCGStab/test_bicgstab_hb.cpp Lines 123 to 128 in 6b8ca47
!Line: 123 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] Trilinos/packages/belos/tpetra/example/GCRODR/GCRODRTpetraExFile.cpp Lines 121 to 126 in 6b8ca47
!Line: 121 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] Trilinos/packages/belos/tpetra/example/GCRODR/GCRODRTpetraExFile.cpp Lines 142 to 147 in 6b8ca47
!Line: 142 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] Trilinos/packages/belos/tpetra/example/GCRODR/GCRODRTpetraExFile.cpp Lines 142 to 147 in 6b8ca47
!Line: 142 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] Trilinos/packages/belos/tpetra/example/GCRODR/GCRODRTpetraExFile.cpp Lines 144 to 149 in 6b8ca47
!Line: 144 - warning: variable 'map' is not initialized [cppcoreguidelines-init-variables] Trilinos/packages/belos/tpetra/example/BlockGmres/PseudoBlockGmresTpetraExFile.cpp Lines 119 to 124 in 6b8ca47
!Line: 119 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] Trilinos/packages/belos/tpetra/example/BlockGmres/PseudoBlockGmresTpetraExFile.cpp Lines 139 to 144 in 6b8ca47
!Line: 139 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] Trilinos/packages/belos/tpetra/example/BlockGmres/PseudoBlockGmresTpetraExFile.cpp Lines 139 to 144 in 6b8ca47
!Line: 139 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] Trilinos/packages/belos/tpetra/example/BlockGmres/PseudoBlockGmresTpetraExFile.cpp Lines 141 to 146 in 6b8ca47
!Line: 141 - warning: variable 'map' is not initialized [cppcoreguidelines-init-variables] Trilinos/packages/belos/tpetra/example/BlockGmres/PseudoBlockGmresTpetraExFile.cpp Lines 210 to 215 in 6b8ca47
!Line: 210 - warning: variable 'resid' is not initialized [cppcoreguidelines-init-variables] Trilinos/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp Lines 90 to 95 in 6b8ca47
!Line: 90 - warning: function 'getCmdLineArgs' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace] Trilinos/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp Lines 90 to 95 in 6b8ca47
!Line: 90 - warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays,hicpp-avoid-c-arrays,modernize-avoid-c-arrays] Trilinos/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp Lines 167 to 172 in 6b8ca47
!Line: 167 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] Trilinos/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp Lines 170 to 175 in 6b8ca47
!Line: 170 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] Trilinos/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp Lines 173 to 178 in 6b8ca47
!Line: 173 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] Trilinos/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp Lines 179 to 184 in 6b8ca47
!Line: 179 - warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments-calls] Trilinos/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp Lines 208 to 213 in 6b8ca47
!Line: 208 - warning: parameter name 'M' is too short, expected at least 3 characters [readability-identifier-length] Trilinos/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp Lines 209 to 214 in 6b8ca47
!Line: 209 - warning: parameter 'debugOut' is unused [misc-unused-parameters] Trilinos/packages/belos/tpetra/test/OrthoManager/belos_orthomanager_tpetra.cpp Lines 229 to 234 in 6b8ca47
!Line: 229 - warning: parameter name 'M' is too short, expected at least 3 characters [readability-identifier-length] Trilinos/packages/belos/tpetra/example/LSQR/LSQRTpetraExFile.cpp Lines 154 to 159 in 6b8ca47
!Line: 154 - warning: variable 'A' is not initialized [cppcoreguidelines-init-variables] Trilinos/packages/belos/tpetra/example/LSQR/LSQRTpetraExFile.cpp Lines 154 to 159 in 6b8ca47
!Line: 154 - warning: variable name 'A' is too short, expected at least 3 characters [readability-identifier-length] |
Fixes #210
IMPORTANT : Prerequities before requesting PR to trilinos/trilinos:develop
Because this PR is modifying previous PR's - and some are still i review on trilinos/trilinos:develop: