Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #131
Tests found under the
test
,example*
directories.VbrMatrix.cpp
- This test can't be converted because it's using aEpetra::VbrMatrix
which doesn't exists inTpetra
package. It was present at some point in the past but it was deprecated and removed from the package as stated in the Release Notes: https://github.com/NexGenAnalytics/Trilinos/blob/NGA-FY23-develop/packages/tpetra/ReleaseNotes.txt#L438cxx_main.cpp
/LinearProblem.cpp
- Those two have a creation of necessary objects for calculations done, but there are no linear solvers inGaleri
/Tpetra
package which could be used to solve the problem. I added a comment that those solvers can be found for example inAmesos2
orIfpack2
.CrsMatrix.cpp
- Original tests used a helper method which generated and printed a 2D stencil of the matrix. I didn't found any good replacement for that, and I didn't create my own.In the tests there are methods used from
Galeri::Xpetra
namespace so they will requireXpetra
to be enabled.