Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#131: Galeri: Add Tpetra tests #136

Merged
merged 5 commits into from
Sep 21, 2023
Merged

Conversation

thearusable
Copy link
Collaborator

@thearusable thearusable commented Aug 24, 2023

Closes #131

Tests found under the test, example* directories.

Folder Epetra Tests (Main file name) Conversion Status
test/VerySimple cxx_main.cpp Partial
example Map.cpp Full
example CrsMatrix.cpp Partial
example VbrMatrix.cpp NO
example LinearProblem.cpp Partial
  • VbrMatrix.cpp - This test can't be converted because it's using a Epetra::VbrMatrix which doesn't exists in Tpetra package. It was present at some point in the past but it was deprecated and removed from the package as stated in the Release Notes: https://github.com/NexGenAnalytics/Trilinos/blob/NGA-FY23-develop/packages/tpetra/ReleaseNotes.txt#L438
  • cxx_main.cpp / LinearProblem.cpp - Those two have a creation of necessary objects for calculations done, but there are no linear solvers in Galeri/Tpetra package which could be used to solve the problem. I added a comment that those solvers can be found for example in Amesos2 or Ifpack2.
  • CrsMatrix.cpp - Original tests used a helper method which generated and printed a 2D stencil of the matrix. I didn't found any good replacement for that, and I didn't create my own.

In the tests there are methods used from Galeri::Xpetra namespace so they will require Xpetra to be enabled.

@stmcgovern stmcgovern merged commit 9575fcf into NGA-FY23-develop Sep 21, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Galeri: Provide Tpetra versions of Epetra only tests
2 participants