#94: Remove use of MPI_COMM_WORLD in Krino package #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -84,7 +84,7 @@ Startup::Startup(int argc, char ** argv) | |||
| throw std::runtime_error("MPI_Init failed"); | |||
| } | |||
|
|
|||
| stk::EnvData::instance().m_parallelComm = MPI_COMM_WORLD; | |||
There was a problem hiding this comment.
This function calls MPI_Init so it makes sense to use MPI_COMM_WORLD here (there's no comm split happening)
| @@ -75,7 +76,7 @@ class BoundingBoxMesh { | |||
| public: | |||
| BoundingBoxMesh(stk::topology element_topology, const std::vector<std::string>& rank_names = std::vector<std::string>()); | |||
| void set_domain(const BoundingBoxType & mesh_bbox, const double mesh_size, const int pad_cells = 0); | |||
| void populate_mesh(stk::ParallelMachine pm = MPI_COMM_WORLD, const stk::mesh::BulkData::AutomaticAuraOption auto_aura_option = stk::mesh::BulkData::AUTO_AURA); | |||
There was a problem hiding this comment.
I think having MPI_COMM_WORLD as default value is ok, if the user wants, he'll just use different comm
|
I'm ok with the changes, but I think the use of |
|
@JacobDomagala Ok, in this case I think it would be good to close this PR. @stmcgovern What do you think? |
cwschilly
force-pushed
the
94-krino-remove-use-of-MPI_COMM_WORLD
branch
from
ed68bf9
to
3c3acfe
Compare
|
Default argument use of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #94