Implements ImplementNotifyPropertyChanged for DictionaryPropertyAcces…

…sor (part of issue #90)
NeutroniumCore · Nov 6, 2018 · ad60792 · ad60792
1 parent 163d698
commit ad60792
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/Neutronium.Core/Infra/Reflection/DictionaryPropertyAccessor.cs b/Neutronium.Core/Infra/Reflection/DictionaryPropertyAccessor.cs
@@ -9,7 +9,7 @@ public sealed class DictionaryPropertyAccessor<T> : IGenericPropertyAcessor
     {
         public IReadOnlyList<PropertyAccessor> ReadProperties => _ReadProperties;
         public IReadOnlyList<string> AttributeNames => _AttributeNames;
-        public ObjectObservability Observability => ObjectObservability.None;
+        public ObjectObservability Observability { get; }
 
         private readonly IDictionary<string, PropertyAccessor> _PropertyAccessoresDictionary;
         private readonly List<PropertyAccessor> _ReadProperties;
@@ -21,6 +21,8 @@ internal DictionaryPropertyAccessor(IDictionary<string,T> dictionary)
             _ReadProperties = readProperties;
             _AttributeNames = readProperties.Select(p => p.Name).ToList();
             _PropertyAccessoresDictionary = ReadProperties.ToDictionary(prop => prop.Name, prop => prop);
+            Observability = Types.NotifyPropertyChanged.IsInstanceOfType(dictionary) ?
+                ObjectObservability.ImplementNotifyPropertyChanged : ObjectObservability.None;
         }
 
         public PropertyAccessor GetAccessor(string propertyName)

diff --git a/Tests/Neutronium.Core.Test/Infra/Reflection/DictionaryPropertyAccessorTest.cs b/Tests/Neutronium.Core.Test/Infra/Reflection/DictionaryPropertyAccessorTest.cs
@@ -1,4 +1,6 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
+using System.Dynamic;
 using System.Linq;
 using FluentAssertions;
 using MoreCollection.Extensions;
@@ -37,6 +39,16 @@ public void Observability_is_none()
             _DictionaryPropertyAccessor.Observability.Should().Be(ObjectObservability.None);
         }
 
+        [Theory]
+        [InlineData(typeof(Dictionary<string, object>), ObjectObservability.None)]
+        [InlineData(typeof(ExpandoObject), ObjectObservability.ImplementNotifyPropertyChanged)]
+        public void Observability_is_acurate(Type dynamicType, ObjectObservability expected)
+        {
+            var @object = (IDictionary<string, object>)Activator.CreateInstance(dynamicType);
+            var dictionaryPropertyAccessor = new DictionaryPropertyAccessor<object>(@object);
+            dictionaryPropertyAccessor.Observability.Should().Be(expected);
+        }
+
         [Fact]
         public void ReadProperties_are_ordered_by_position()
         {