Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable offset, conversion and channel conversion in mock_ElectricalSeries #1796

Conversation

h-mayorquin
Copy link
Contributor

@h-mayorquin h-mayorquin commented Dec 10, 2023

Motivation

I use this functions often for quick tests and and I am interested in having in testing scenarios that involve those attributes. Currently, they are not available so the goal of this PR is to enable them. Note those arguments are enabled in mock_TimeSeries as well so this makes the signatures more consistent.

https://github.com/h-mayorquin/pynwb/blob/8c4d62cc9c67645b04a2633b14148bcbbe2a8c45/src/pynwb/testing/mock/base.py#L10-L27

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change?
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

Copy link

codecov bot commented Dec 10, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87a7c57) 91.97% compared to head (056f5fd) 91.97%.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1796   +/-   ##
=======================================
  Coverage   91.97%   91.97%           
=======================================
  Files          27       27           
  Lines        2617     2617           
  Branches      683      683           
=======================================
  Hits         2407     2407           
  Misses        138      138           
  Partials       72       72           
Flag Coverage Δ
integration 71.22% <ø> (ø)
unit 83.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rly
Copy link
Contributor

rly commented Dec 12, 2023

Good idea. Please fix the flake8 error and add a changelog.

@h-mayorquin h-mayorquin marked this pull request as ready for review December 12, 2023 13:28
@h-mayorquin
Copy link
Contributor Author

@rly done.

@rly rly merged commit 0e45cd9 into NeurodataWithoutBorders:dev Dec 13, 2023
23 of 24 checks passed
@h-mayorquin h-mayorquin deleted the offest_and_conversion_arguments_in_mock_electrical_series branch December 14, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants