-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update TimeIntervals.timeseries to use new TimeSeriesReferenceVectorData #486
Conversation
Looks good. Please update the version strings in docs/format/source/conf.py, core/nwb.namespace.yaml, and /core/nwb.file.yaml to "2.5.0-alpha" |
Looks good. Feel free to squash and merge. |
Would this sort of reference object make sense to use for waveform columns on a UnitsTable? We often have difficulty getting the properties of that column to properly match TimeSeries-like attributes. What do you think @oruebel @bendichter
Would it also apply to custom TimeInterval table objects placed in, say, a 'processing' module? |
Yes, this updates the
I'm not sure. This would require storing the waveforms in (likely many individual) |
Motivation
#470 added the new
TimeSeriesReferenceVectorData
type. This PR updatesTimeIntervals
to use the newTimeSeriesReferenceVectorData
type. This does not alter the overall structure ofTimeIntervals
in a major way aside from changing the value of theneurodata_type
attribute in the file fromVectorData
toTimeSeriesReferenceVectorData
. This change replaces the existingTimeIntervals.timeseries
column with aTimeSeriesReferenceVectorData
type column of the same name and overall schema. This change facilitate creating common functionality aroundTimeSeriesReferenceVectorData
. This change affects all existingTimeIntervals
tables as part of theintervals/
group, i.e.,intervals/epochs
,intervals/trials
, andintervals/invalid_times
(#470)Summary of changes
TimeIntervals
to use the newTimeSeriesReferenceVectorData
typeRelates PRs
NeurodataWithoutBorders/pynwb#1390 is the matching PR on PyNWB for this
PR checklist for schema changes
docs/format/source/conf.py
,core/nwb.namespace.yaml
, and/core/nwb.file.yaml
to the next version with the suffix "-alpha"
docs/format/source/format_release_notes.rst