Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove quantity from OptogeneticStimulusSite and ImagingPlane definitions #472

Merged
merged 4 commits into from
Aug 5, 2021
Merged

Remove quantity from OptogeneticStimulusSite and ImagingPlane definitions #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2e36e84
Remove quantity from OptogeneticStimulusSite definition
rly Apr 21, 2021
2bfaa1d
Remove quantity from ImagingPlane
rly Apr 21, 2021
94b8249
Merge branch 'dev' into fix/quantity_ogen
rly Aug 5, 2021
520d86a
Update format_release_notes.rst
rly Aug 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion core/nwb.ogen.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ groups:
- neurodata_type_def: OptogeneticStimulusSite
neurodata_type_inc: NWBContainer
doc: A site of optogenetic stimulation.
quantity: '*'
datasets:
- name: description
dtype: text
Expand Down
1 change: 0 additions & 1 deletion core/nwb.ophys.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,6 @@ groups:
- neurodata_type_def: ImagingPlane
neurodata_type_inc: NWBContainer
doc: An imaging plane and its metadata.
quantity: '*'
datasets:
- name: description
dtype: text
Expand Down
4 changes: 3 additions & 1 deletion docs/format/source/format_release_notes.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
Release Notes
=============

2.4.0 (Upcoming)
2.4.0 (Aug. 7, 2021)
----------------

- Fix incorrect dtype for electrodes table column "filtering" (float -> text)
- Remove "quantity: *" from the type definitions of ``OptogeneticStimulusSite`` and ``ImagingPlane``.
This change improves clarity of the schema to follow best practices. It has no functional effect on the schema.

2.3.0 (May 12, 2021)
---------------------
Expand Down