Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split base tests from end to end, regenerate screenshots #913

Merged
merged 13 commits into from
Aug 15, 2024
Merged

Conversation

rly
Copy link
Collaborator

@rly rly commented Aug 15, 2024

@rly
Copy link
Collaborator Author

rly commented Aug 15, 2024

I changed npm run coverage:app to no longer run end-to-end tests. To run the end-to-end tests, use npm run coverage:tutorial. I also moved puppeteer.ts into the e2e test folder and made puppeteer a dev dependency. Lastly, I regenerated the screenshots and changed the dandiset for test upload to be a new one that I own, and I updated the DANDI_STAGING_API_KEY secret for this repo to my staging dandiset key.

@rly rly requested a review from CodyCBakerPhD August 15, 2024 00:44
@rly
Copy link
Collaborator Author

rly commented Aug 15, 2024

@CodyCBakerPhD feel free to suggest alternate names and organization. Just thought I would try to do this while it was fresh in my mind. Also the screenshots needed updating.

@CodyCBakerPhD CodyCBakerPhD marked this pull request as ready for review August 15, 2024 04:18
@CodyCBakerPhD
Copy link
Collaborator

@rly Looks great! Thanks a bunch

@CodyCBakerPhD CodyCBakerPhD merged commit 6356e1f into main Aug 15, 2024
27 checks passed
@CodyCBakerPhD CodyCBakerPhD deleted the e2e branch August 15, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants