-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Linux branch #519
Conversation
As discussed by @rly in the Slack, we may want to merge this into @CodyCBakerPhD Is there a way that you can access the builds created here and see whether they are even of a different size than the |
The reason this has been on a side branch all this time is because we cannot successfully build any distributable from this branch |
Ah, I see. For reference, the error from electron-builder is
Let's keep the current installation method for Linux then, until we find a better solution. |
for more information, see https://pre-commit.ci
@garrettmflynn Could you submit a review with a 'requested change' somewhere here to make this that much harder (nigh impossible) to accidentally merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding this to block accidental merges. This PR should be kept separate for the convenience of Linux users.
replaced by #670 |
DO NOT MERGE
Opening this draft PR to make it easy to keep up to date with main