Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Linux branch #519

Closed
wants to merge 27 commits into from
Closed

[DO NOT MERGE] Linux branch #519

wants to merge 27 commits into from

Conversation

CodyCBakerPhD
Copy link
Collaborator

DO NOT MERGE

Opening this draft PR to make it easy to keep up to date with main

@garrettmflynn
Copy link
Member

As discussed by @rly in the Slack, we may want to merge this into main for the sake of simplicity if this works for Mac and Windows—even if we have a slightly larger distributable size.

@CodyCBakerPhD Is there a way that you can access the builds created here and see whether they are even of a different size than the main branch?

@CodyCBakerPhD
Copy link
Collaborator Author

As discussed by @rly in the Slack, we may want to merge this into main for the sake of simplicity if this works for Mac and Windows—even if we have a slightly larger distributable size.

@CodyCBakerPhD Is there a way that you can access the builds created here and see whether they are even of a different size than the main branch?

The reason this has been on a side branch all this time is because we cannot successfully build any distributable from this branch

https://github.com/NeurodataWithoutBorders/nwb-guide/actions/runs/6946096739/job/18896843132

https://github.com/NeurodataWithoutBorders/nwb-guide/actions/runs/6946098457/job/18896849262

@rly
Copy link
Collaborator

rly commented Nov 21, 2023

Ah, I see. For reference, the error from electron-builder is

  ⨯ Package "electron" is only allowed in "devDependencies". Please remove it from the "dependencies" section in your package.json.

Let's keep the current installation method for Linux then, until we find a better solution.

@CodyCBakerPhD
Copy link
Collaborator Author

@garrettmflynn Could you submit a review with a 'requested change' somewhere here to make this that much harder (nigh impossible) to accidentally merge?

@garrettmflynn garrettmflynn self-requested a review January 29, 2024 20:11
Copy link
Member

@garrettmflynn garrettmflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this to block accidental merges. This PR should be kept separate for the convenience of Linux users.

@CodyCBakerPhD
Copy link
Collaborator Author

replaced by #670

@CodyCBakerPhD CodyCBakerPhD deleted the linux-fix branch March 13, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants