Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ErrorID and warningID for all user-facing code #617

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ehennestad
Copy link
Collaborator

@ehennestad ehennestad commented Nov 5, 2024

Fix #11

Motivation

Fix issue

How to test the behavior?

N/A

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

@ehennestad
Copy link
Collaborator Author

ehennestad commented Nov 5, 2024

Todo:

  • Go through all calls to the assert function.
  • Multiline error / warning calls negatively impacts coverage...

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 35.00000% with 26 lines in your changes missing coverage. Please review.

Project coverage is 90.69%. Comparing base (5aa27d9) to head (b02f126).

Files with missing lines Patch % Lines
+file/Dataset.m 0.00% 4 Missing ⚠️
+file/fillProps.m 0.00% 4 Missing ⚠️
+file/Group.m 0.00% 2 Missing ⚠️
+file/fillValidators.m 50.00% 2 Missing ⚠️
+io/getBaseType.m 0.00% 2 Missing ⚠️
+io/writeCompound.m 0.00% 2 Missing ⚠️
+io/writeDataset.m 0.00% 2 Missing ⚠️
+misc/str2validName.m 0.00% 2 Missing ⚠️
+types/+util/checkDependent.m 0.00% 2 Missing ⚠️
+file/fillConstructor.m 50.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #617      +/-   ##
==========================================
- Coverage   90.91%   90.69%   -0.22%     
==========================================
  Files         107      107              
  Lines        4753     4763      +10     
==========================================
- Hits         4321     4320       -1     
- Misses        432      443      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warnings and errors should have IDs
1 participant