Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOT MERGE including optuna #606

Closed
wants to merge 13 commits into from

Conversation

bruAristimunha
Copy link
Collaborator

No description provided.

@bruAristimunha
Copy link
Collaborator Author

A small revision is welcome @tomMoral

Copy link
Collaborator

@tomMoral tomMoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few comments

moabb/evaluations/evaluations.py Outdated Show resolved Hide resolved
moabb/evaluations/evaluations.py Outdated Show resolved Hide resolved
moabb/evaluations/evaluations.py Outdated Show resolved Hide resolved
moabb/evaluations/evaluations.py Outdated Show resolved Hide resolved
@bruAristimunha
Copy link
Collaborator Author

@sylvchev, we are ready to spend a lot of credit on Jeay Zay! I need help!

@tomMoral
Copy link
Collaborator

can you share the output for a small model with this code?

@bruAristimunha
Copy link
Collaborator Author

I am using this example to make the test: https://github.com/NeuroTechX/moabb/blob/develop/examples/plot_benchmark_DL.py

and everything is working.

@bruAristimunha
Copy link
Collaborator Author

@carraraig, can you copy the logic in this branch into another branch to run the augmentation covariance matrix with optuna for bcni? With this, even if Optuna does not improve the deep learning, is enough for the large benchmark paper.

@bruAristimunha
Copy link
Collaborator Author

the update from today's conversations....

@bruAristimunha
Copy link
Collaborator Author

closed to the detriment #630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants