-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalise runs and sessions names #471
Normalise runs and sessions names #471
Conversation
This comment will be removed from the code but is relatively important:
|
I liked it, but I'm unsure if this won't break something in the braindecode. Maybe we need to do something more activate. Add a little sub test routine or something else. |
I will review the PR more carefully |
Let’s normalise session and run suffixes to “test” and “train”. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @PierreGtch this is really a nice API breaking change ^^
closes #472 |
This is ready to merge @bruAristimunha @sylvchev |
Amazing work @PierreGtch. I need to pay you a beer =) |
dataset.get_data
that verifies if the runs and sessions and subjects are correctly named