Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipelines for MsetCCA SSVEP, TRCA SSVEP, and others #368

Merged
merged 4 commits into from
May 17, 2023

Conversation

emmanuelkalunga
Copy link
Collaborator

This PR will contain pipelines for benchmark purposes.
To be done:

  • MsetCCA-SSVEP pipeline
  • TRCA-SSVEP pipeline
  • Test benchmark with various pipeline parameters

Copy link
Collaborator

@carraraig carraraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Only some small modification and we can merge this PR.

pipelines/MsetCCA-SSVEP.yml Outdated Show resolved Hide resolved
pipelines/TRCA-SSVEP.yml Show resolved Hide resolved
pipelines/TRCA-SSVEP.yml Outdated Show resolved Hide resolved
@carraraig
Copy link
Collaborator

Hi @emmanuelkalunga !

I saw that the pipeline MsetCCA require a freq parameter that we need to get automatically from the paradigm is that correct?
And same for TRCA-SSVEP that require interval and freq.

We need to get this parameter directly in act of creation of the pipeline since the benchmark function can run on several dataset. Make sense to your implementation?

@carraraig
Copy link
Collaborator

carraraig commented May 17, 2023

The plan is to run each pipeline with dataset specific regarding the benchmark results.
The main issue is that this pipeline need some information from dataset specific, this problem will be taken in account in a new PR (#376)

@carraraig carraraig marked this pull request as ready for review May 17, 2023 14:17
@carraraig carraraig merged commit 3a0e646 into NeuroTechX:develop May 17, 2023
@carraraig
Copy link
Collaborator

Thank you for the great work @emmanuelkalunga !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants