[Dataset] Brain Invaders dataset with VR/PC display #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruAristimunha
requested changes
Apr 14, 2023
|
Hi @gcattan! So nice, a new dataset! Very happy with your addition! In addition to the comments, some small points:
|
Co-authored-by: Bru <[email protected]>
Co-authored-by: Bru <[email protected]>
Co-authored-by: Bru <[email protected]>
Co-authored-by: Bru <[email protected]>
bruAristimunha
approved these changes
Apr 14, 2023
Co-authored-by: Bru <[email protected]>
improve styling of chnames Co-authored-by: Bru <[email protected]>
Add dataset summary for the VirtualReality dataset Co-authored-by: Bru <[email protected]>
- add new fake dataset
|
Everything is fine for me! @sylvchev, can you give the final check and apply the merge? |
bruAristimunha
approved these changes
Apr 18, 2023
sylvchev
reviewed
Apr 19, 2023
There was a problem hiding this comment.
Thanks @gcattan for this nice PR. I made some suggestions, could you make the change ? We could merge your PR afterwards.
The get_block_repetition is very nice, it could be very interesting to generalized this approach to other P300 datasets, where it could be applied.
Co-authored-by: Sylvain Chevallier <[email protected]>
Co-authored-by: Sylvain Chevallier <[email protected]>
Co-authored-by: Sylvain Chevallier <[email protected]>
Co-authored-by: Sylvain Chevallier <[email protected]>
Co-authored-by: Sylvain Chevallier <[email protected]>
Co-authored-by: Sylvain Chevallier <[email protected]>
|
Thanks for the review @sylvchev. Yes, Pedro had a nice idea with the |
|
Thank you for the new dataset @gcattan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sylvchev This PR is a follow-up on the work you did already with bi2014/bi2015.
It is a proposal to integrate the Brain Invaders with VR dataset (https://github.com/plcrodrigues/py.VR.EEG.2018-GIPSA) in MOABB.
@plcrodrigues FYI