replacing the np.int to native type int. #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylvchev
approved these changes
Jan 24, 2023
|
I corrected most of it in a previous PR. Thanks for spotting this! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally discovered what was blocking a NumPy version update. In the latest ubuntu docker images, native NumPy is installed with a version above 1.20. It's a bit of work to install the lower version, I thought it best to create this pull request and replace the type alias of NumPy.
Better explanation in NumPy release notes 1.20: https://numpy.org/devdocs/release/1.20.0-notes.html