-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grid Search on Evaluation #319
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @carraraig
I spotted some weird loop in your code. Could you explained the reason for this loops or change your code to avoid repeating a grid search?
I merge the return_raw PR and there are some conflict now, but they should be easy to solved. |
I agree with the problem, and solved as proposed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modification submitted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a nice PR, you could add grid search for benchmark when the tests are fixed
Thanks @carraraig ! |
Grid Search implementation for the different evaluation function.