-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return raw with get_data #302
Conversation
Can I review this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look's good to me!
I couldn't find any significant changes. But, I am not 100% family with the moabb code. For me, we can follow, and I will try to implement the braindecode pipeline.
dataset specific i | ||
nformation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dataset specific i | |
nformation. | |
dataset specific information |
Hi @sylvchev, I exposed the parameter return_raws. Can you review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me!
In order to comply with BrainDecode standard, data should be available as raw files. This PR implements this first step to be able to plug BrainDecode models into MOABB evaluation (and to ease the extension of MOABBDataset class in BrainDecode)