Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return raw with get_data #302

Merged
merged 8 commits into from
Jan 17, 2023
Merged

Conversation

sylvchev
Copy link
Member

In order to comply with BrainDecode standard, data should be available as raw files. This PR implements this first step to be able to plug BrainDecode models into MOABB evaluation (and to ease the extension of MOABBDataset class in BrainDecode)

@bruAristimunha
Copy link
Collaborator

Can I review this PR?

Copy link
Collaborator

@bruAristimunha bruAristimunha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look's good to me!

I couldn't find any significant changes. But, I am not 100% family with the moabb code. For me, we can follow, and I will try to implement the braindecode pipeline.

Comment on lines +63 to +64
dataset specific i
nformation.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dataset specific i
nformation.
dataset specific information

@sylvchev sylvchev self-assigned this Dec 31, 2022
@bruAristimunha
Copy link
Collaborator

Hi @sylvchev,

I exposed the parameter return_raws. Can you review?

Copy link
Member Author

@sylvchev sylvchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants