Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize cVEP datasets description columns #566

Closed
1 of 2 tasks
PierreGtch opened this issue Apr 11, 2024 · 2 comments
Closed
1 of 2 tasks

Normalize cVEP datasets description columns #566

PierreGtch opened this issue Apr 11, 2024 · 2 comments
Labels

Comments

@PierreGtch
Copy link
Collaborator

PierreGtch commented Apr 11, 2024

  • To improve clarity in the doc, @thijor and I propose to change the docstrings and summary tables of cVEP (and eventually ERP) to these columns:
=============  ======= ========= ============= ===== ============= ============== =============== ============== ===============
Name           #Subj   #Sessions Sampling rate #Chan Trials length #Trial classes #Trials / class #Epoch classes #Epochs / class   
=============  ======= ========= ============= ===== ============= ============== =============== ============== ===============

With the following definitions:

  • Trials length is the duration of one symbol selection

  • #Trial classes is the number of different symbols

  • #Trials / class number of trials per symbol in each session

  • #Epoch classes for a visual cVEP paradigm, this would be the number of flash intensities

  • #Epochs / class the number of flashes per intensity in each session

  • And we should add those definitions to the dataset summary table

(see #557 and #562)

@PierreGtch
Copy link
Collaborator Author

PierreGtch commented Apr 11, 2024

I forgot the Presentation rate, frequency at which the flashes are presented

@PierreGtch
Copy link
Collaborator Author

Also forgot Codes

PierreGtch added a commit to bruAristimunha/moabb that referenced this issue Apr 11, 2024
PierreGtch added a commit to bruAristimunha/moabb that referenced this issue Apr 11, 2024
PierreGtch added a commit to bruAristimunha/moabb that referenced this issue Apr 11, 2024
PierreGtch added a commit to bruAristimunha/moabb that referenced this issue Apr 11, 2024
PierreGtch added a commit that referenced this issue Apr 11, 2024
…cription tables (#562)

* fixing the issues

* fixing the dataset doc

* adding whats_new.rst

* more typos

* more typo

* Apply suggestions from code review

Co-authored-by: PierreGtch <[email protected]>

* new dataset convention

* new table

* Add presentation rate to castillos2023.py

* Update table of thielen2021.py #566

* Update table of thielen2015.py #566

* Update summary table #566

* Fix presentation rate thielen2015.py

* Add codes to docstring tables #566

* Update whats_new.rst

---------

Co-authored-by: PierreGtch <[email protected]>
Co-authored-by: Pierre Guetschel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants