Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: pass down trial parameter to subclass. #276

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pellet
Copy link
Contributor

@pellet pellet commented Oct 2, 2024

bugfix: pass down trial parameter to subclass as was previously done before VR code modified rendering logic.

Also fixed baseclass 'present_stimulus' method signature to match arguments as expected for subclass to implement.

This was something which I accidentally had modified the behaviour of - I had trouble understanding what the 'trial' parameter was used for in the experiments.
It seems like none of the example experiments are using the parameter.

…before VR code modified rendering logic.

Also fixed baseclass 'present_stimulus' method signature to match arguments as expected for subclass to implement.
@JohnGriffiths
Copy link
Collaborator

@pellet - summary from discussion:

looks like the trial variable actually wasn't ever being used

could you please first check that in the rest of the code and confirm

if so, update this PR to remove that variable entirely as it's redundant

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants