Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For NML v2.1 release #143

Merged
merged 40 commits into from
Mar 22, 2021
Merged

For NML v2.1 release #143

merged 40 commits into from
Mar 22, 2021

Conversation

pgleeson
Copy link
Member

No description provided.

pgleeson and others added 30 commits May 10, 2019 16:52
* development:
  Update .travis.yml
  Update .travis.yml
Also include a flake configuration file that ignores a few warnings.
In py3, one cannot modify a dictionary while it is being iterated.
generate.py: Fix for python39 and cosmetic tweaks
To display correct conversion values, we limit the precision context to
2 places (required by Hz). Higher precisions, such as the default
machine precision, include the usual issues with floating point
arithmetic and do not display exact conversions.

References:
- https://docs.python.org/3/tutorial/floatingpoint.html
- https://docs.python.org/3/library/decimal.html#module-decimal

Fixes #134
fix(generate.py): use Decimal to correctly report conversion factors
Adding e (elementary charge) as unit for charge
This breaks our doc generation otherwise.
@pgleeson pgleeson added this to the NeuroML 2.1 release milestone Mar 18, 2021
@pgleeson pgleeson merged commit a7a5d56 into master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants