feat(repeater): implement HTTP request runner #87
Conversation
|
Code Climate has analyzed commit 4423771 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 96.4% (50% is the threshold). This pull request will bring the total coverage in the repository to 95.9%. View more on Code Climate. |
derevnjuk
force-pushed
the
feat_#85/implement_HTTP_request_runner
branch
from
c05ae44
to
8a7c55d
Compare
| _mockHttp.VerifyNoOutstandingExpectation(); | ||
| result.Should().BeEquivalentTo(new | ||
| { | ||
| Message = "The operation was canceled." |
There was a problem hiding this comment.
Fact culture has to be tied to en-US
There was a problem hiding this comment.
Nope at all, fluent assertions behave the same no matter the culture of the machine being run on
There was a problem hiding this comment.
This message looks similar to one from OperationCancelledException and it will be localized to the current user culture
There was a problem hiding this comment.
It should be localized, but it is not. You can easily verify this by running tests with LC_ env on Linux-like. I would highly appreciate you checking if the tests passed on Windows with zh-CN. If so, I don't see any reason to do this
test/SecTester.Repeater.Tests/Runners/HttpRequestRunnerTests.cs
Outdated
Show resolved
Hide resolved
closes #85