feat(repeater): adopt self-deploying repeaters #175
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 11416982 | Triggered | Generic High Entropy Secret | 9b215af | test/SecTester.Repeater.Tests/Bus/DefaultRepeaterBusFactoryTests.cs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
ostridm
force-pushed
the
feat_#174/adopt-self-delpoying-repeater
branch
from
515d8ed
to
ccf313f
Compare
Bumps [braces](https://github.com/micromatch/braces) from 3.0.2 to 3.0.3. - [Changelog](https://github.com/micromatch/braces/blob/master/CHANGELOG.md) - [Commits](micromatch/braces@3.0.2...3.0.3) --- updated-dependencies: - dependency-name: braces dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
ostridm
force-pushed
the
feat_#174/adopt-self-delpoying-repeater
branch
from
ccf313f
to
4606a14
Compare
….0.3' into feat_#174/adopt-self-delpoying-repeater
closes #174
|
Code Climate has analyzed commit 9d2577c and detected 2 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 96.2% (0.0% change). View more on Code Climate. |
| @@ -2,5 +2,5 @@ namespace SecTester.Repeater.Bus; | |||
|
|
|||
| public interface IRepeaterBusFactory | |||
There was a problem hiding this comment.
See NeuraLegion/sectester-js#197 (comment). Let's rename to IBridgeService
…epeater' into feat_#174/adopt-self-delpoying-repeater
|
@ostridm the last commit consists a unwanted chagnes. you have to preserve the ability to use the predefined ID. The user of SecTester.Repeater should be able to run a repeater with a constant ID. Such changes in the public interface must be avoided. |
This reverts commit 0db1321.
closes #174