-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bus): remove AMQP communication transport #173
feat(bus): remove AMQP communication transport #173
Conversation
BREAKING CHANGE: The `SecTester.Bus` package, which was intended to provide support of communication via the AMQP transport is removed. This change simplifies the codebase by removing deprecated options and encourages the use of more modern and supported transport methods. closes #172
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11416982 | Triggered | Generic High Entropy Secret | 6a60344 | test/SecTester.Bus.Tests/Extensions/ServiceCollectionExtensionsTests.cs | View secret |
11416982 | Triggered | Generic High Entropy Secret | 6a60344 | test/SecTester.Repeater.Tests/Extensions/ServiceCollectionExtensionsTests.cs | View secret |
11416982 | Triggered | Generic High Entropy Secret | 6f49979 | test/SecTester.Core.Tests/Extensions/ServiceCollectionExtensionsTests.cs | View secret |
11416982 | Triggered | Generic High Entropy Secret | 6f49979 | test/SecTester.Repeater.Tests/Extensions/ServiceCollectionExtensionsTests.cs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Code Climate has analyzed commit 155536e and detected 4 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 96.2% (-0.3% change). View more on Code Climate. |
…qp-communication-transport
@ostridm 0.x.x is used to indicate we are still under heavy development 😄 The breaking change are legal |
closes #172