Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bus): remove AMQP communication transport #173

Merged
merged 7 commits into from
Jun 17, 2024

Conversation

ostridm
Copy link
Contributor

@ostridm ostridm commented Jun 12, 2024

closes #172

BREAKING CHANGE: The `SecTester.Bus` package, which was intended to provide support of communication via the AMQP transport is removed. This change simplifies the codebase by removing deprecated options and encourages the use of more modern and supported transport methods.

closes #172
@ostridm ostridm added the Type: enhancement New feature or request. label Jun 12, 2024
@ostridm ostridm self-assigned this Jun 12, 2024
Copy link

gitguardian bot commented Jun 12, 2024

⚠️ GitGuardian has uncovered 4 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11416982 Triggered Generic High Entropy Secret 6a60344 test/SecTester.Bus.Tests/Extensions/ServiceCollectionExtensionsTests.cs View secret
11416982 Triggered Generic High Entropy Secret 6a60344 test/SecTester.Repeater.Tests/Extensions/ServiceCollectionExtensionsTests.cs View secret
11416982 Triggered Generic High Entropy Secret 6f49979 test/SecTester.Core.Tests/Extensions/ServiceCollectionExtensionsTests.cs View secret
11416982 Triggered Generic High Entropy Secret 6f49979 test/SecTester.Repeater.Tests/Extensions/ServiceCollectionExtensionsTests.cs View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

codeclimate bot commented Jun 12, 2024

Code Climate has analyzed commit 155536e and detected 4 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Duplication 3

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 96.2% (-0.3% change).

View more on Code Climate.

@ostridm ostridm marked this pull request as ready for review June 13, 2024 09:48
@derevnjuk
Copy link
Member

@ostridm 0.x.x is used to indicate we are still under heavy development 😄 The breaking change are legal

SecTester.sln Outdated Show resolved Hide resolved
src/SecTester.Repeater/Internal/HttpMethods.cs Outdated Show resolved Hide resolved
@ostridm ostridm requested a review from derevnjuk June 17, 2024 08:18
@derevnjuk derevnjuk merged commit c0b1190 into master Jun 17, 2024
6 checks passed
@derevnjuk derevnjuk deleted the feat_#172/remove-amqp-communication-transport branch June 17, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: enhancement New feature or request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove AMQP communication transport
2 participants