Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repeater): resolve bridges service communication #171

Merged
merged 13 commits into from
Jun 8, 2024

Conversation

ostridm
Copy link
Contributor

@ostridm ostridm commented May 24, 2024

closes #170

@ostridm ostridm added the Type: enhancement New feature or request. label May 24, 2024
@ostridm ostridm self-assigned this May 24, 2024
Copy link

codeclimate bot commented May 24, 2024

Code Climate has analyzed commit 425e6d2 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

The test coverage on the diff in this pull request is 91.5% (50% is the threshold).

This pull request will bring the total coverage in the repository to 96.6%.

View more on Code Climate.

@ostridm ostridm changed the title feat(repeater): establish bridges service integration feat(repeater): resolve bridges service communication May 24, 2024
@ostridm ostridm requested a review from derevnjuk May 27, 2024 12:27
@ostridm ostridm marked this pull request as ready for review May 28, 2024 05:28
src/SecTester.Repeater/Bus/HttpMessage.cs Outdated Show resolved Hide resolved
src/SecTester.Repeater/Bus/HttpMessage.cs Outdated Show resolved Hide resolved
src/SecTester.Repeater/Bus/SocketIoMessage.cs Outdated Show resolved Hide resolved
src/SecTester.Repeater/Protocol.cs Outdated Show resolved Hide resolved
@derevnjuk derevnjuk changed the title feat(repeater): resolve bridges service communication fix(repeater): resolve bridges service communication May 31, 2024
@derevnjuk derevnjuk added Type: bug Something isn't working and removed Type: enhancement New feature or request. labels May 31, 2024
@ostridm ostridm requested a review from derevnjuk June 1, 2024 09:55
@derevnjuk derevnjuk force-pushed the feat_#170/bridges-service-integration branch from 5260f38 to 039daad Compare June 7, 2024 22:05
derevnjuk
derevnjuk previously approved these changes Jun 7, 2024
@derevnjuk derevnjuk force-pushed the feat_#170/bridges-service-integration branch from 039daad to 23c8dde Compare June 8, 2024 05:41
@derevnjuk derevnjuk force-pushed the feat_#170/bridges-service-integration branch from 23c8dde to 425e6d2 Compare June 8, 2024 05:45
@derevnjuk derevnjuk merged commit d7dce84 into master Jun 8, 2024
6 checks passed
@derevnjuk derevnjuk deleted the feat_#170/bridges-service-integration branch June 8, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolve Bridges service communication issues
2 participants