Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CI discovery provider #88

Closed
Tracked by #45
ostridm opened this issue Dec 6, 2022 · 2 comments · Fixed by #94
Closed
Tracked by #45

Implement CI discovery provider #88

ostridm opened this issue Dec 6, 2022 · 2 comments · Fixed by #94
Assignees
@ostridm
Labels
Type: refactoring Changes in the way the code works internally without changing the output produced.

Comments

@ostridm
Copy link
Contributor

ostridm commented Dec 6, 2022

Implement CI Discovery provider compatible with ci-info package which is used by sectester-js
@ostridm ostridm added the Type: enhancement New feature or request. label Dec 6, 2022
@ostridm ostridm self-assigned this Dec 6, 2022
@ostridm ostridm mentioned this issue Dec 6, 2022
Closed
8 tasks
@derevnjuk derevnjuk added Type: refactoring Changes in the way the code works internally without changing the output produced. and removed Type: enhancement New feature or request. labels Dec 6, 2022
@ostridm ostridm added Type: enhancement New feature or request. and removed Type: refactoring Changes in the way the code works internally without changing the output produced. labels Dec 7, 2022
ostridm added a commit that referenced this issue Dec 8, 2022
@ostridm
feat(scan): implement CI discovery provider
4dcbe74 
closes #88
ostridm added a commit that referenced this issue Dec 8, 2022
@ostridm
feat(scan): implement CI discovery provider
403e997 
closes #88
ostridm added a commit that referenced this issue Dec 8, 2022
@ostridm
feat(scan): implement CI discovery provider
af9cc6c 
closes #88
ostridm added a commit that referenced this issue Dec 8, 2022
@ostridm
feat(scan): implement CI discovery provider
4fd4261 
closes #88
@ostridm ostridm mentioned this issue Dec 8, 2022
Merged
ostridm added a commit that referenced this issue Dec 9, 2022
@ostridm
feat(scan): implement CI discovery provider
af65123 
closes #88
ostridm added a commit that referenced this issue Dec 9, 2022
@ostridm
feat(scan): implement CI discovery provider
a20de3b 
closes #88
ostridm added a commit that referenced this issue Dec 9, 2022
@ostridm
feat(scan): implement CI discovery provider
32dfc24 
closes #88
ostridm added a commit that referenced this issue Dec 9, 2022
@ostridm
feat(scan): implement CI discovery provider
144eab6 
closes #88
derevnjuk pushed a commit that referenced this issue Dec 9, 2022
@ostridm @derevnjuk
feat(scan): implement CI discovery provider
c35e469 
closes #88
@derevnjuk derevnjuk added Type: refactoring Changes in the way the code works internally without changing the output produced. and removed Type: enhancement New feature or request. labels Dec 9, 2022
@derevnjuk
Copy link
Member

@ostridm you don't change API nor change the behavior, this is refactoring

@derevnjuk
Copy link
Member

@ostridm you know, I would say this is still refactor since CIDiscovery is internal

ostridm added a commit that referenced this issue Dec 9, 2022
@ostridm
feat(scan): implement CI discovery provider
48054c5 
closes #88
ostridm added a commit that referenced this issue Dec 9, 2022
@ostridm
feat(scan): implement CI discovery provider
8299192 
adjust according to code review
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)

closes #88
ostridm added a commit that referenced this issue Dec 9, 2022
@ostridm
feat(scan): implement CI discovery provider
9f898d4 
adjust according to code review
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)

closes #88
ostridm added a commit that referenced this issue Dec 9, 2022
@ostridm
feat(scan): implement CI discovery provider
2388172 
closes #88
ostridm added a commit that referenced this issue Dec 9, 2022
@ostridm
feat(scan): implement CI discovery provider
fd32a51 
adjust according to code review
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)

closes #88
ostridm added a commit that referenced this issue Dec 12, 2022
@ostridm
refactor(scan): implement CI discovery provider
370774c 
adjust according to code review
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)

closes #88
ostridm added a commit that referenced this issue Dec 12, 2022
@ostridm
refactor(scan): implement CI discovery provider
a7a5dc6 
adjust according to code review
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)
#94 (comment)

closes #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ostridm ostridm

Labels
Type: refactoring Changes in the way the code works internally without changing the output produced.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(scan): implement CI discovery provider NeuraLegion/sectester-net
2 participants
@ostridm @derevnjuk