ci: fix node20 compatibility issues in e2e pipeline #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The git checkout step is failing as actions/checkout actions has started using node20 be default. Since node20 requires GLIBC version 2.28 and upper, our tests that run on Ubunu 16.04 and 18.04 are failing. The solution is to add ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true env variable.
derevnjuk
reviewed
Nov 11, 2024
There was a problem hiding this comment.
Please follow the contributing guide: the short description should clearly indicate what was done, while the PR body should explain the purpose of these changes if it’s not obvious from the changes itself. While you used a generic statement for the short description and provided detailed explanations in the body.
E.g.
ci: fix node20 compatibility issues in e2e pipeline
e2e pipeline fails on Ubuntu 16.04 and 18.04 due to the recent default switch to node20 in actions/checkout. Node20 requires GLIBC 2.28 or higher, which these environments lack. To resolve this, we’re setting the `ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true` environment variable to allow fallback to a compatible Node version, restoring pipeline stability.
Useful links:
* [GitHub changelog: node20 default](https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/)
* [GitHub issue #1809](https://github.com/actions/checkout/issues/1809)
maksadbek
changed the title
derevnjuk
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e2e pipeline fails on Ubuntu 16.04 and 18.04 due to the recent default switch to node20 in actions/checkout. Node20 requires GLIBC 2.28 or higher, which these environments lack. To resolve this, we’re setting the
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=trueenvironment variable to allow fallback to a compatible Node version, restoring pipeline stability.Useful links: