Skip to content

Commit

Permalink
chore: fix e2e test pipeline
Browse files Browse the repository at this point in the history
The git checkout step is failing as actions/checkout actions has started
using node20 be default. Since node20 requires GLIBC version 2.28 and
upper, our tests that run on Ubunu 16.04 and 18.04 are failing. The
solution is to add ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true env
variable.
  • Loading branch information
maksadbek committed Nov 10, 2024
1 parent 6e57c57 commit 3a0657e
Showing 1 changed file with 12 additions and 3 deletions.
15 changes: 12 additions & 3 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,9 @@ jobs:
if: ${{ inputs.test-executables }}
runs-on: ${{ matrix.os }}
container: ${{ matrix.container }}
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -94,7 +97,7 @@ jobs:
&& rm -rf /var/lib/apt/lists/*
- name: Checkout Repository
uses: actions/checkout@v2
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2

- name: Download Executable
shell: bash
Expand Down Expand Up @@ -125,6 +128,7 @@ jobs:
E2E_REPEATER_TARGET_URL: ${{ format('http://localhost:{0}', steps.target.outputs.port) }}
E2E_REPEATER_TARGET_CMD: ${{ steps.target.outputs.cmd }}
E2E_TEST_TIMEOUT: ${{ inputs.test_timeout }}

msi:
if: ${{ inputs.test-msi }}
runs-on: windows-latest
Expand Down Expand Up @@ -175,6 +179,7 @@ jobs:
E2E_REPEATER_TARGET_URL: ${{ format('http://localhost:{0}', steps.target.outputs.port) }}
E2E_REPEATER_TARGET_CMD: ${{ steps.target.outputs.cmd }}
E2E_TEST_TIMEOUT: ${{ inputs.test_timeout }}

docker:
if: ${{ inputs.test-docker }}
runs-on: ${{ matrix.os }}
Expand All @@ -193,7 +198,7 @@ jobs:
run: docker pull brightsec/cli:${{ inputs.version }}

- name: Checkout Repository
uses: actions/checkout@v2
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2

- name: Download Target
id: target
Expand All @@ -217,10 +222,14 @@ jobs:
E2E_REPEATER_TARGET_URL: ${{ format('http://host.docker.internal:{0}', steps.target.outputs.port) }}
E2E_REPEATER_TARGET_CMD: ${{ steps.target.outputs.cmd }}
E2E_TEST_TIMEOUT: ${{ inputs.test_timeout }}

npm:
if: ${{ inputs.test-npm }}
runs-on: ${{ matrix.os }}
container: ${{ matrix.container }}
env:
ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -257,7 +266,7 @@ jobs:
&& rm -rf /var/lib/apt/lists/*
- name: Checkout Repository
uses: actions/checkout@v2
uses: actions/checkout@ee0669bd1cc54295c223e0bb666b733df41de1c5 # v2

- name: Download Target
id: target
Expand Down

0 comments on commit 3a0657e

Please sign in to comment.