feat(*): address PR comments

closes #600
NeuraLegion · Oct 29, 2024 · 0700a37 · 0700a37
1 parent 0e143c5
commit 0700a37
Showing 1 changed file with 10 additions and 8 deletions.
diff --git a/src/Utils/ErrorMessageFactory.ts b/src/Utils/ErrorMessageFactory.ts
@@ -5,28 +5,30 @@ type GenericCommandErrorParams =
   | { message: string; error: unknown };
 
 export class ErrorMessageFactory {
-  public static genericCommandError(params: GenericCommandErrorParam): string {
+  public static genericCommandError(params: GenericCommandErrorParams): string {
     const message = this.getMessageTitle(params);
-    const details = this.getMessageDetails(params);
+    const details = this.extractErrorDetails(params);
 
     return this.formatFinalMessage(message, details);
   }
-
-  private static formatFinalMessage(baseMessage: string, errorDetails?: string): string {
-    return errorDetails 
+
+  private static formatFinalMessage(
+    baseMessage: string,
+    errorDetails?: string
+  ): string {
+    return errorDetails
       ? `${baseMessage}: ${errorDetails}.`
       : `${baseMessage}.`;
   }
-  }
 
-  private static getMessageTitle(params: GenericCommandErrorParam): string {
+  private static getMessageTitle(params: GenericCommandErrorParams): string {
     return 'message' in params
       ? params.message
       : `Error during "${params.command}"`;
   }
 
   private static extractErrorDetails(
-    params: GenericCommandErrorParam
+    params: GenericCommandErrorParams
   ): string | null {
     if (typeof params.error === 'string') {
       return params.error;