Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OP Holocene fork (retry) #7794

Open
wants to merge 48 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
Show all changes
48 commits
Select commit Hold shift + click to select a range
6f0395e
Perform single dependency capture
emlautarom1 Nov 7, 2024
fda85b9
Add Holocene to ReleaseSpec
emlautarom1 Nov 7, 2024
32ee4f7
Decode EIP1559 parameters from BlockHeader
emlautarom1 Nov 7, 2024
5a8e70c
Validate ExtraData fields post-Holocene
emlautarom1 Nov 7, 2024
c8aa891
Collapse test cases
emlautarom1 Nov 7, 2024
e0f5d5e
Test for pre-Holocene ExtraData validation
emlautarom1 Nov 7, 2024
d9a5c12
Extract to interface
emlautarom1 Nov 8, 2024
35d6ef0
Allow for "zero" EIP1559 parameters
emlautarom1 Nov 8, 2024
412fdbc
Add concrete `Eip1559Spec : IEip1559Spec`
emlautarom1 Nov 11, 2024
315cc23
Add helper methods
emlautarom1 Nov 11, 2024
0ce5908
Add OptimismBaseFeeCalculator
emlautarom1 Nov 11, 2024
22fc7ad
Remove unused using
emlautarom1 Nov 11, 2024
3d14ce3
Add `EIP1559Params` to `OptimismPayloadAttributes`
emlautarom1 Nov 11, 2024
a66b367
Rename file
emlautarom1 Nov 12, 2024
defe8f7
Use correct version
emlautarom1 Nov 13, 2024
ecabab6
Decode EIP1559 parameters from `OptimismPayloadAttributes`
emlautarom1 Nov 13, 2024
b7db888
Include EIP1559 params from attributes into block header
emlautarom1 Nov 13, 2024
aef8a7c
Extract required length to constant
emlautarom1 Nov 13, 2024
67c6577
Remove unused constructor
emlautarom1 Nov 13, 2024
551976c
Test payload validation before Holocene
emlautarom1 Nov 13, 2024
53b6f8e
Reintroduce `BaseFeeCalculator` singleton
emlautarom1 Nov 13, 2024
ae5c231
Fix wrong test name
emlautarom1 Nov 13, 2024
97831af
Mark tests parallelizable
emlautarom1 Nov 13, 2024
44bbeeb
Override `BaseFeeCalculator` in OP
emlautarom1 Nov 13, 2024
db743b6
Use init only properties
emlautarom1 Nov 14, 2024
96675ab
Use `nameof`
emlautarom1 Nov 14, 2024
1405f1b
Remove nullability
emlautarom1 Nov 14, 2024
6469275
Add Holocene timestamp for Sepolia
emlautarom1 Nov 14, 2024
4603248
Add Holocene parameters
emlautarom1 Nov 14, 2024
fcd733d
Merge branch 'master' into feat/optimism-holocene
emlautarom1 Nov 14, 2024
c7b37b5
Ensure `ExtraData.Length == 9`
emlautarom1 Nov 14, 2024
d9fd3e4
Add placeholder timestamp for mainnet
emlautarom1 Nov 15, 2024
4013c7a
Merge branch 'master' into feat/optimism-holocene
benaadams Nov 19, 2024
96e57e3
Perform single `IsZero` check
emlautarom1 Nov 20, 2024
b1ba8a4
Rename class
emlautarom1 Nov 20, 2024
83e2f84
Prefer errors over Exceptions
emlautarom1 Nov 20, 2024
1d10135
Make `IBaseFeeCalculator` part of `IEip1559Spec`
emlautarom1 Nov 20, 2024
2c77b7b
Use `IEip1559Spec.IBaseFeeCalculator` in singleton
emlautarom1 Nov 20, 2024
18444bd
Inject `IBaseFeeCalculator` through `IChainSpecEngineParameters`
emlautarom1 Nov 20, 2024
bdf4d23
Make `HoloceneTimestamp` optional
emlautarom1 Nov 20, 2024
377829c
Fix substitutes
emlautarom1 Nov 20, 2024
0792ec4
Avoid whitespace diff
emlautarom1 Nov 20, 2024
9ea6945
Merge branch 'master' into feat/optimism-holocene
emlautarom1 Nov 20, 2024
e3ad51c
Extract constant
emlautarom1 Nov 21, 2024
5ff8dff
Merge branch 'master' into feat/optimism-holocene
emlautarom1 Nov 21, 2024
55e1fb6
Merge branch 'master' into feat/optimism-holocene
emlautarom1 Nov 21, 2024
4192a4e
Merge branch 'master' into feat/optimism-holocene
emlautarom1 Nov 22, 2024
d38dbd1
Remove transitions
emlautarom1 Nov 22, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// SPDX-License-Identifier: LGPL-3.0-only

using System;
using System.Collections.Generic;
using Nethermind.Core;
using Nethermind.Int256;
using Nethermind.Specs;
Expand Down Expand Up @@ -39,22 +38,6 @@ public class OptimismChainSpecEngineParameters : IChainSpecEngineParameters

public byte[]? Create2DeployerCode { get; set; }

public void AddTransitions(SortedSet<long> blockNumbers, SortedSet<ulong> timestamps)
{
ArgumentNullException.ThrowIfNull(BedrockBlockNumber);
ArgumentNullException.ThrowIfNull(RegolithTimestamp);
ArgumentNullException.ThrowIfNull(CanyonTimestamp);
ArgumentNullException.ThrowIfNull(EcotoneTimestamp);
ArgumentNullException.ThrowIfNull(FjordTimestamp);
ArgumentNullException.ThrowIfNull(GraniteTimestamp);
blockNumbers.Add(BedrockBlockNumber.Value);
timestamps.Add(RegolithTimestamp.Value);
timestamps.Add(CanyonTimestamp.Value);
timestamps.Add(EcotoneTimestamp.Value);
timestamps.Add(FjordTimestamp.Value);
timestamps.Add(GraniteTimestamp.Value);
}

public void ApplyToReleaseSpec(ReleaseSpec spec, long startBlock, ulong? startTimestamp)
{
ArgumentNullException.ThrowIfNull(CanyonBaseFeeChangeDenominator);
Expand Down
Loading