-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#7746 jwtfile path correction #7765
Open
ssonthal
wants to merge
15
commits into
NethermindEth:master
Choose a base branch
from
ssonthal:7746_update_jwt_path
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
f11fcfa
jwtfile path correction
ssonthal f4fd623
Some fixes
ssonthal a104cf8
default as null explicitly
ssonthal 64ef390
suggested changes
ssonthal 731588e
suggested changes
ssonthal a9708a8
Merge branch 'master' into 7746_update_jwt_path
ssonthal 1d32886
Update JsonRpcConfig.cs
ssonthal c200cfd
Merge branch 'master' into 7746_update_jwt_path
ssonthal b357386
Merge branch 'master' into 7746_update_jwt_path
ssonthal 50612b7
Merge branch 'master' into 7746_update_jwt_path
ssonthal 3d507d1
suggested changes
ssonthal 2e9d08a
adding warning messages
ssonthal 3d58984
typo fix
ssonthal 493ea51
Merge branch 'master' into 7746_update_jwt_path
ssonthal cb8d026
Merge branch 'master' into 7746_update_jwt_path
ssonthal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a side note: if you intend to take corrective action then they are info logs and not warning logs.
for now until we decide if we need to move or not based on @MarekM25 response,
we can just leave it as is.