t8n test #7744
Open
t8n test #7744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yerke26
requested review from
rubo,
LukaszRozmej and
MarekM25
as code owners
|
@rubo should we add it to github actions? |
| @@ -29,7 +29,7 @@ public ReceiptForRpc(Hash256 txHash, TxReceipt receipt, TxGasInfo gasInfo, int l | |||
| BlobGasPrice = gasInfo.BlobGasPrice; | |||
| From = receipt.Sender; | |||
| To = receipt.Recipient; | |||
| ContractAddress = receipt.ContractAddress; | |||
| ContractAddress = receipt.ContractAddress ?? Address.Zero; | |||
There was a problem hiding this comment.
Why would we serialize Address.Zero for transactions that don't create contracts?
This will also affect all the RPC method, are we sure we want to do it?
If we don't want to change RPC methods, but we want to change it here, you can inherit ReceiptForRpc and add this logic in the derived class.
| } | ||
|
|
||
| [Test] | ||
| public void Test6() |
There was a problem hiding this comment.
Can you name tests in some sensible way? I see it is based on testdata so Test13_txs_London?
| @@ -95,6 +95,6 @@ private static (ISpecProvider, IReleaseSpec) GetSpec(T8nCommandArguments argumen | |||
| specProvider.UpdateMergeTransitionInfo(env.CurrentNumber, 0); | |||
| } | |||
|
|
|||
| return (specProvider, overridableReleaseSpec); | |||
| return (specProvider, overridableReleaseSpec, spec); | |||
There was a problem hiding this comment.
why do you need to differentiate between 2x release specs?
| { | ||
| public IReleaseSpec Spec { get; set; } = spec; | ||
| public IReleaseSpec OverridableReleaseSpec { get; set; } = overridableReleaseSpec; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added t8n tests, fixed t8n code
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.