Add client id to admin_peers RPC API

[anhnhgutech]

Add client id to admin_peers RPC API

Related #7536

Changes

• Add id to admin_peers RPC API
• Update clientId -> name

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• Yes
• No

If yes, did you write tests?

• Yes
• No

Screenshots

Notes

Regarding updating the clientId parameter to name, I believe that refers to the client name. However, I've only updated it in the admin_peers RPC API, keeping clientId unchanged in other functions.

[LukaszRozmej]

Regarding updating the clientId parameter to name, I believe that refers to the client name. However, I've only updated it in the admin_peers RPC API, keeping clientId unchanged in other functions.

Where else should we check?

[anhnhgutech]

Regarding updating the clientId parameter to name, I believe that refers to the client name. However, I've only updated it in the admin_peers RPC API, keeping clientId unchanged in other functions.

Where else should we check?

You use ClientId in many places, but I think it is currently like a client name, right?
In this PR, I only updated the API; if you want, I can create another PR to change all var name ClientId to ClientName
Ex:

nethermind/src/Nethermind/Nethermind.Network/P2P/Messages/HelloMessage.cs

Line 15 in 1318d52

public string ClientId { get; set; }

[LukaszRozmej]

Regarding updating the clientId parameter to name, I believe that refers to the client name. However, I've only updated it in the admin_peers RPC API, keeping clientId unchanged in other functions.

Where else should we check?

You use ClientId in many places, but I think it is currently like a client name, right? In this PR, I only updated the API; if you want, I can create another PR to change all var name ClientId to ClientName Ex:

nethermind/src/Nethermind/Nethermind.Network/P2P/Messages/HelloMessage.cs

Line 15 in 1318d52

public string ClientId { get; set; }

Nah lets leave P2P messages out of this, it is a different context.
Hello message specs it as clientId: https://github.com/ethereum/devp2p/blob/master/rlpx.md#hello-0x00
Hence the naming in Peers as they are constructed based on that.

[LukaszRozmej]

Btw do we need to calculate it here, we have already peer.Node.IdHash?

[anhnhgutech]

I see, let me check again.

[anhnhgutech]

I see that IdHash is calculated by PrefixedBytes, this isn’t the clientId.

IdHash = Keccak.Compute(PublicKey.PrefixedBytes);

I think we should use new CalculateClientId function, right?

[LukaszRozmej]

Not sure, it is your PR ;)
Best to check with Geth code.

[LukaszRozmej]

Yeah IdHash should be fine

[LukaszRozmej]

Change to IdHash

[anhnhgutech]

Change to IdHash

@LukaszRozmej
I mean, the IdHash doesn't seem to be the same as ClientId, they are different.
By the way, as you can see, in admin_nodeInfo, the Nethermind team calculates ClientId the same way as in my PR

nethermind/src/Nethermind/Nethermind.JsonRpc/Modules/Admin/AdminRpcModule.cs

Lines 49 to 61 in 458266e

	private void BuildNodeInfo()
	{
	_nodeInfo = new NodeInfo();
	_nodeInfo.Name = ProductInfo.ClientId;
	_nodeInfo.Enode = _enode.Info;
	byte[] publicKeyBytes = _enode.PublicKey?.Bytes;
	_nodeInfo.Id = (publicKeyBytes is null ? Keccak.Zero : Keccak.Compute(publicKeyBytes)).ToString(false);
	_nodeInfo.Ip = _enode.HostIp?.ToString();
	_nodeInfo.ListenAddress = $"{_enode.HostIp}:{_enode.Port}";
	_nodeInfo.Ports.Discovery = _networkConfig.DiscoveryPort;
	_nodeInfo.Ports.Listener = _networkConfig.P2PPort;
	UpdateEthProtocolInfo();
	}

[LukaszRozmej]

Closing in favor of #7717