Avoid expensive Stelem_Ref covariant checks in Trie #7675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Oct 29, 2024
Comment on lines
+772
to
+777
| if ((uint)index > (uint)data.Length) | ||
| { | ||
| // Since we are accessing unsafely we need to do our own | ||
| // bounds check to ensure is safe; as the Jit won't help us. | ||
| ThrowIndexOutOfRangeException(); | ||
| } |
There was a problem hiding this comment.
I wonder if we could skip the checks in release mode as the index should come from previous logic and be correct (we never had out of range exception on this path)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
object[]Types of changes
What types of changes does your code introduce?
Testing
Requires testing