Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to System.CommandLine for tools #7672

Merged
merged 12 commits into from
Oct 29, 2024
Merged

Switch to System.CommandLine for tools #7672

merged 12 commits into from
Oct 29, 2024

Conversation

rubo
Copy link
Contributor

@rubo rubo commented Oct 28, 2024 •
edited
Loading

See #7653. The changes applied as a separate PR for easier review.

Changes

  • DocGen: Replaced Spectre.Console.Cli with System.CommandLine
  • HiveCompare: Replaced McMaster.Extensions.CommandLineUtils with System.CommandLine
  • Kute: Replaced CommandLineParser with System.CommandLine
  • SendBlobs: Replaced McMaster.Extensions.CommandLineUtils with System.CommandLine
  • Nethermind.Cli: Replaced McMaster.Extensions.CommandLineUtils with System.CommandLine

No API or CLI usage changes

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

@rubo rubo requested review from flcl42 and emlautarom1 October 28, 2024 15:10
emlautarom1
emlautarom1 approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@emlautarom1 emlautarom1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small details but LGTM

tools/Nethermind.Tools.Kute/ResponseTracer/FileResponseTracer.cs Outdated Show resolved Hide resolved
tools/DocGen/Properties/launchSettings.json Show resolved Hide resolved
tools/Nethermind.Tools.Kute/Config.cs Outdated Show resolved Hide resolved
tools/Nethermind.Tools.Kute/Config.cs Outdated Show resolved Hide resolved
tools/Nethermind.Tools.Kute/Config.cs Outdated Show resolved Hide resolved
tools/Nethermind.Tools.Kute/Program.cs Show resolved Hide resolved
tools/SendBlobs/SetupCli.cs Outdated Show resolved Hide resolved
tools/nuget.config Show resolved Hide resolved
tools/nuget.config Show resolved Hide resolved
@rubo rubo merged commit 8277892 into feature/system-commandline-2 Oct 29, 2024
58 of 61 checks passed
@rubo rubo deleted the feature/tools-system-commandline branch October 29, 2024 09:36
@rubo rubo mentioned this pull request Nov 1, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emlautarom1 emlautarom1 emlautarom1 approved these changes

@flcl42 flcl42 flcl42 approved these changes

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rubo @flcl42 @emlautarom1