Switch to Microsoft.IdentityModel.JsonWebTokens package #7269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszRozmej
approved these changes
Jul 18, 2024
| return handler.CreateToken(new SecurityTokenDescriptor | ||
| { | ||
| IssuedAt = _clock.UtcNow.UtcDateTime, | ||
| SigningCredentials = new(new SymmetricSecurityKey(_secret), SecurityAlgorithms.HmacSha256) |
There was a problem hiding this comment.
Should we cache SymmetricSecurityKey instance?
There was a problem hiding this comment.
I tried not to make any other changes but replace the API as I don't know much about Kute. But the suggested change is small enough, so applied in the commit below.
There was a problem hiding this comment.
There should be no need for caching since we're already caching the JWT generation. By default, this code will be executed once per minute.
emlautarom1
reviewed
Jul 18, 2024
| } | ||
|
|
||
| private string GenerateAuthToken() | ||
| { | ||
| var signingKey = new SymmetricSecurityKey(_secret); | ||
| var credentials = new SigningCredentials(signingKey, SecurityAlgorithms.HmacSha256); | ||
| var claims = new[] { new Claim(JwtRegisteredClaimNames.Iat, _clock.UtcNow.ToUnixTimeSeconds().ToString(), ClaimValueTypes.Integer64) }; |
There was a problem hiding this comment.
It's failing to compile:
MSBuild version 17.8.5+b5265ef37 for .NET
Determining projects to restore...
Restored /root/nethermind/tools/Nethermind.Tools.Kute/Nethermind.Tools.Kute.csproj (in 3.61 sec).
/root/nethermind/tools/Nethermind.Tools.Kute/JsonRpcMethodFilter/ComposedJsonRpcMethodFilter.cs(18,18): error CS1061: 'IEnumerable<IJsonRpcMethodFilter>' does not contain a definition for 'IsNullOrEmpty' and no accessible extension method 'IsNullOrEmpty' accepting a first argument of type 'IEnumerable<IJsonRpcMethodFilter>' could be found (are you missing a using directive or an assembly reference?) [/root/nethermind/tools/Nethermind.Tools.Kute/Nethermind.Tools.Kute.csproj]
Build FAILED.
/root/nethermind/tools/Nethermind.Tools.Kute/JsonRpcMethodFilter/ComposedJsonRpcMethodFilter.cs(18,18): error CS1061: 'IEnumerable<IJsonRpcMethodFilter>' does not contain a definition for 'IsNullOrEmpty' and no accessible extension method 'IsNullOrEmpty' accepting a first argument of type 'IEnumerable<IJsonRpcMethodFilter>' could be found (are you missing a using directive or an assembly reference?) [/root/nethermind/tools/Nethermind.Tools.Kute/Nethermind.Tools.Kute.csproj]
There was a problem hiding this comment.
@emlautarom1 The updated code has been tested to ensure it generates the same token as it was with the replaced package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replaced the
System.IdentityModel.Tokens.Jwtpackage withMicrosoft.IdentityModel.JsonWebTokensas recommended by Microsoft:For the Nethermind client, the replaced package is no longer needed after #7177.
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?