Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove repository dispatch token usage #7191

Merged
merged 4 commits into from
Jun 21, 2024

Conversation

cbermudez97
Copy link
Contributor

Changes

  • Remove REPOSITORY_DISPATCH_TOKEN usage in Github workflows

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Github workflows

@cbermudez97 cbermudez97 requested review from rubo and a team as code owners June 17, 2024 19:42
Copy link
Contributor

@rubo rubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please restore the single quotes.

@cbermudez97
Copy link
Contributor Author

cbermudez97 commented Jun 18, 2024

@rubo noticed some workflows here that use the old token to call to Dappnodes repository. I'm not aware if this is something still in usage. Just to remove as our GH app wont have access to any external repository.

Links:
https://github.com/NethermindEth/nethermind/blob/ci/remove-dispatch-token/.github/workflows/update-dappnode-package.yml
https://github.com/NethermindEth/nethermind/blob/ci/remove-dispatch-token/.github/workflows/release.yml#L204-L210

cc @kamilchodola

@kamilchodola kamilchodola merged commit 94458e0 into master Jun 21, 2024
68 checks passed
@kamilchodola kamilchodola deleted the ci/remove-dispatch-token branch June 21, 2024 14:27
@rubo
Copy link
Contributor

rubo commented Jun 21, 2024

Why was this merged without addressing the requested changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants