Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization/cache precompiles #7106

Merged
merged 309 commits into from
Jun 12, 2024
Merged

Conversation

LukaszRozmej
Copy link
Member

@LukaszRozmej LukaszRozmej commented May 29, 2024

Changes

  • Adds cache for precompile results from parallel execution
  • Optimizes precompiles on allocations and stack
  • refactors and simplifies some precompile code
  • hookups caches in other block processors (AuRa, AuRaMerge, Optimism)

Types of changes

What types of changes does your code introduce?

  • Bugfix (a non-breaking change that fixes an issue)
  • New feature (a non-breaking change that adds functionality)
  • Breaking change (a change that causes existing functionality not to work as expected)
  • Optimization
  • Refactoring
  • Documentation update
  • Build-related changes
  • Other: Description

Testing

Requires testing

  • Yes
  • No

If yes, did you write tests?

  • Yes
  • No

Notes on testing

Optional. Remove if not applicable.

Documentation

Requires documentation update

  • Yes
  • No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

  • Yes
  • No

If yes, fill in the details here. Remove if not applicable.

Remarks

Optional. Remove if not applicable.

Copy link
Member

@benaadams benaadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfomance is good

Base automatically changed from feature/eth_multicall to master June 10, 2024 14:56
…mization/cache-precompiles

# Conflicts:
#	src/Nethermind/Nethermind.Optimism/InitializeBlockchainOptimism.cs
…precompiles

# Conflicts:
#	src/Nethermind/Nethermind.Consensus/Processing/ReadOnlyTxProcessingEnv.cs
#	src/Nethermind/Nethermind.Consensus/Processing/ReadOnlyTxProcessingEnvBase.cs
#	src/Nethermind/Nethermind.Consensus/Processing/ReadOnlyTxProcessingEnvFactory.cs
#	src/Nethermind/Nethermind.Core/Buffers/CappedArray.cs
#	src/Nethermind/Nethermind.Evm/CodeInfoRepository.cs
#	src/Nethermind/Nethermind.Facade/Simulate/SimulateOutput.cs
#	src/Nethermind/Nethermind.Facade/Simulate/SimulateTxMutatorTracer.cs
#	src/Nethermind/Nethermind.Init/Steps/InitializeBlockchain.cs
#	src/Nethermind/Nethermind.JsonRpc.Test/Modules/Eth/EthSimulateTestsPrecompilesWithRedirection.cs
#	src/Nethermind/Nethermind.JsonRpc.Test/Modules/Eth/Simulate/EthSimulateTestsBlocksAndTransactions.cs
#	src/Nethermind/Nethermind.JsonRpc.Test/Modules/Eth/Simulate/EthSimulateTestsSimplePrecompiles.cs
#	src/Nethermind/Nethermind.Optimism/InitializeBlockchainOptimism.cs
#	src/Nethermind/Nethermind.State/OverlayWorldStateManager.cs
#	src/Nethermind/Nethermind.State/PreBlockCaches.cs
#	src/Nethermind/Nethermind.State/ReadOnlyWorldStateManager.cs
@LukaszRozmej LukaszRozmej marked this pull request as ready for review June 12, 2024 09:56
@LukaszRozmej LukaszRozmej requested review from asdacap and flcl42 June 12, 2024 09:58
@LukaszRozmej LukaszRozmej merged commit 2e0e5c1 into master Jun 12, 2024
68 checks passed
@LukaszRozmej LukaszRozmej deleted the optimization/cache-precompiles branch June 12, 2024 20:08
LukaszRozmej added a commit that referenced this pull request Jun 18, 2024
@LukaszRozmej LukaszRozmej mentioned this pull request Jun 18, 2024
5 tasks
LukaszRozmej added a commit that referenced this pull request Jun 19, 2024
benaadams added a commit that referenced this pull request Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants