Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast Call to Non contract addresses #7074

Merged
merged 4 commits into from
May 27, 2024
Merged

Fast Call to Non contract addresses #7074

merged 4 commits into from
May 27, 2024

Conversation

benaadams
Copy link
Member

@benaadams benaadams commented May 25, 2024 •
edited
Loading

Changes

  • If a call is to a non-contract address; just transfer the value rather than constructing a full call frame
    • between 1% to 10% of calls per block are to non-contract (i.e. effectively only ETH transfers)

Types of changes

What types of changes does your code introduce?

  • Optimization

Testing

Requires testing

  • No

@benaadams benaadams marked this pull request as ready for review May 25, 2024 02:54
@benaadams
Copy link
Member Author

Hive tests pass https://github.com/NethermindEth/nethermind/actions/runs/9232345307

LukaszRozmej
LukaszRozmej reviewed May 25, 2024
View reviewed changes
Copy link
Member

@LukaszRozmej LukaszRozmej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to run cosnesus hive tests

@benaadams
Copy link
Member Author

Would be good to run cosnesus hive tests

https://github.com/NethermindEth/nethermind/actions/runs/9237001249

Same 256 failures as the prewarm branch

https://github.com/NethermindEth/nethermind/actions/runs/9238390120

Checking master

@benaadams
Copy link
Member Author

Consensus hive failures are recent EIP7610 tests ethereum/EIPs#8161

@benaadams benaadams merged commit 3dd1e21 into master May 27, 2024
322 of 327 checks passed
@benaadams benaadams deleted the fastcall branch May 27, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukaszRozmej LukaszRozmej LukaszRozmej approved these changes

@Scooletz Scooletz Awaiting requested review from Scooletz

@Demuirgos Demuirgos Awaiting requested review from Demuirgos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benaadams @LukaszRozmej