Parallel Trie Branch KeyGeneration

[benaadams]

Changes

• For the root of the Trie calculate all the branches keys in parallel (which occurs in the GetLength path)

Before 7+% of block processing

After 1.5% of block processing

Types of changes

What types of changes does your code introduce?

• Optimization

Testing

Requires testing

• No

[benaadams]

Hive test pass https://github.com/NethermindEth/nethermind/actions/runs/9149515737

[LukaszRozmej]

Why this can only be supported for the root key?

[benaadams]

Why this can only be supported for the root key?

🤔 idea was only single level of Parallism, not sure how Parallel.For performs if recursed at each level. Will test

[Scooletz]

🤔 idea was only single level of Parallism, not sure how Parallel.For performs if recursed at each level. Will test

Doesn't it fall into poor parallelism category? Also: how many cores one can expect?

[benaadams]

🤔 idea was only single level of Parallism, not sure how Parallel.For performs if recursed at each level. Will test

Doesn't it fall into poor parallelism category? Also: how many cores one can expect?

In what regard? Isn't it Embarrassingly Parallel? Am more concerned about blocking threads from 16^N splits

[benaadams]

95.1% is in ProcessTransaction; not sure it much gained by further parallising it? vs overheads